ignore: test whether fixtures pass when strictly enforcing feature set#6312
Closed
0xalpharush wants to merge 1 commit intofiredancer-io:mainfrom
Closed
ignore: test whether fixtures pass when strictly enforcing feature set#63120xalpharush wants to merge 1 commit intofiredancer-io:mainfrom
0xalpharush wants to merge 1 commit intofiredancer-io:mainfrom
Conversation
0xalpharush
force-pushed
the
test/solana-conformance-fixtures
branch
from
147b4c7 to
6b226bb
Compare
0xalpharush
force-pushed
the
test/solana-conformance-fixtures
branch
from
6b226bb to
8b23b67
Compare
0xalpharush
changed the title
mjain-jump
requested changes
Sep 10, 2025
Contributor
mjain-jump
left a comment
mjain-jump
left a comment
There was a problem hiding this comment.
by default in FD, any features inside feature_map.json are supported, and any features explicitly marked as cleaned_up / hardcode_for_fuzzing are hardcoded.
Contributor
Author
|
I was attempting to compare to this. It would be a bit strange if the fixtures are passing for features that are not yet implemented, but it's possible the comments are out of date. The failure before it exited early is due to a cleaned up feature, so it didn't reach the intrs fixtures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.