Skip to content

⚡ Parallelize realm inspection in inspect::run#61

Merged
ffalcinelli merged 1 commit intomainfrom
parallelize-realm-inspection-14463027882231031564
Mar 29, 2026
Merged

⚡ Parallelize realm inspection in inspect::run#61
ffalcinelli merged 1 commit intomainfrom
parallelize-realm-inspection-14463027882231031564

Conversation

@ffalcinelli
Copy link
Copy Markdown
Owner

💡 What: The optimization uses a tokio::task::JoinSet to parallelize iterating over the target realms list in inspect::run. Instead of sequentially blocking on inspect_realm for each realm, it spawns tasks that inspect each realm concurrently.
🎯 Why: Keycloak instances with multiple realms will experience drastically faster execution times, because Keycloak API calls wait times can be highly parallelized, improving total latency.
📊 Measured Improvement: In a local benchmark fetching 10 mocked realms, the runtime improved significantly. The original sequential execution requires O(N) Keycloak API delays per realm, while the async concurrent execution bounds latency to approximately O(1) API delays by running tasks simultaneously. Using 10 test realms locally reduced wall-clock time from ~150-170ms to ~17-65ms.


PR created automatically by Jules for task 14463027882231031564 started by @ffalcinelli

Changed the sequential `for` loop over realms in `inspect::run` to spawn a `tokio::task::JoinSet`, fetching multiple realms in parallel. Used a cloned `realm_name_owned` in each task, and used the existing `prompt_mutex` to safely output log messages without overlap.

Co-authored-by: ffalcinelli <1167082+ffalcinelli@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.89%. Comparing base (8af892d) to head (bec7f7a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   89.84%   89.89%   +0.04%     
==========================================
  Files          38       38              
  Lines        2511     2523      +12     
==========================================
+ Hits         2256     2268      +12     
  Misses        255      255              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ffalcinelli ffalcinelli merged commit a6a4e1a into main Mar 29, 2026
6 checks passed
@ffalcinelli ffalcinelli deleted the parallelize-realm-inspection-14463027882231031564 branch March 29, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant