Skip to content

🧪 Add comprehensive edge case tests for obfuscate_string#55

Merged
ffalcinelli merged 1 commit intomainfrom
test-obfuscate-string-edge-cases-17652285989970506663
Mar 24, 2026
Merged

🧪 Add comprehensive edge case tests for obfuscate_string#55
ffalcinelli merged 1 commit intomainfrom
test-obfuscate-string-edge-cases-17652285989970506663

Conversation

@ffalcinelli
Copy link
Copy Markdown
Owner

Added unit tests for the obfuscate_string utility function to ensure reliable masking of sensitive data across various string types, including short strings, multi-byte Unicode characters (emojis), and whitespace. This addresses the testing gap for boundary conditions and non-ASCII character handling.


PR created automatically by Jules for task 17652285989970506663 started by @ffalcinelli

Adds unit tests for `obfuscate_string` in `src/utils/secrets.rs` covering:
- Empty strings
- Short ASCII and Unicode strings (boundary check <= 3 chars)
- Longer ASCII and Unicode strings (boundary check > 3 chars)
- Mixed ASCII/Unicode strings
- Whitespace-only strings

Verified that the implementation correctly handles multi-byte Unicode characters by using character count instead of byte length.

Co-authored-by: ffalcinelli <1167082+ffalcinelli@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ffalcinelli ffalcinelli merged commit dba9d6c into main Mar 24, 2026
4 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.27%. Comparing base (28d41eb) to head (9dd925b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   83.27%   83.27%           
=======================================
  Files          11       11           
  Lines        2296     2296           
=======================================
  Hits         1912     1912           
  Misses        384      384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ffalcinelli ffalcinelli deleted the test-obfuscate-string-edge-cases-17652285989970506663 branch March 24, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant