Skip to content

Fix OSS build #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markbhasawut wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −1
Open

Fix OSS build #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a5ff81
Fix thrift error: could not find include file thrift/annotation/thrif…
markbhasawut Dec 19, 2025
eb7581d
Guarding the internal feature
markbhasawut Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mcrouter/McrouterLogger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ bool McrouterLogger::start() {
} else {
// If default path is not available and TW backup is enabled, try backup
// path
#ifndef MCROUTER_OSS_BUILD
if (router_.opts().enable_tw_crash_config_backup_path &&
additionalLogger_) {
auto backupPath = additionalLogger_->getBackupStatsRootPath();
Expand All @@ -177,11 +178,14 @@ bool McrouterLogger::start() {
return false;
}
} else {
#endif
LOG(WARNING) << "Can't create or chmod " << router_.opts().stats_root
<< ", disabling stats logging";
return false;
}
#ifndef MCROUTER_OSS_BUILD
}
#endif

boost::filesystem::path path(statsRoot_);
path /= getStatPrefix(router_.opts()) + "." + kStatsStartupOptionsSfx;
Expand Down
2 changes: 1 addition & 1 deletion mcrouter/lib/carbon/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ gen-cpp2/carbon_result_types.h: gen-cpp2/carbon_result_types_custom_protocol.h
gen-cpp2/carbon_result_types_custom_protocol.h: gen-cpp2/carbon_result_data.cpp
gen-cpp2/carbon_result_data.cpp: gen-cpp2/carbon_result_data.h
gen-cpp2/carbon_result_data.h: carbon_result.thrift
@FBTHRIFT@ -gen mstch_cpp2:stack_arguments,sync_methods_return_try,include_prefix=mcrouter/lib/carbon/ carbon_result.thrift
@FBTHRIFT@ -gen mstch_cpp2:stack_arguments,sync_methods_return_try,include_prefix=mcrouter/lib/carbon/ -I $(INSTALL_DIR)/include/ carbon_result.thrift

gen-cpp2/carbon_types.cpp: gen-cpp2/carbon_types.h
gen-cpp2/carbon_types_binary.cpp: gen-cpp2/carbon_types.h
Expand Down