Fix OSS build #474
Open
Fix OSS build #474
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.thrift D89334763 introduce the using of `include "thrift/annotation/thrift.thrift"`. ``` Making all in carbon make[4]: Entering directory '/home/runner/work/mcrouter/mcrouter/mcrouter/lib/carbon' /home/runner/work/mcrouter/mcrouter/mcrouter-install/install/bin//thrift1 -gen mstch_cpp2:stack_arguments,sync_methods_return_try,include_prefix=mcrouter/lib/carbon/ carbon_result.thrift /home/runner/work/mcrouter/mcrouter/mcrouter-install/install/bin//thrift1 -gen mstch_cpp2:stack_arguments,sync_methods_return_try,include_prefix=mcrouter/lib/carbon/ -I /home/runner/work/mcrouter/mcrouter/mcrouter-install/install/include/ carbon.thrift [ERROR:carbon_result.thrift:8] Could not find include file thrift/annotation/thrift.thrift make[4]: *** [Makefile:521: gen-cpp2/carbon_result_data.h] Error 1 make[4]: *** Waiting for unfinished jobs.... ``` This should be fixed by `-I $(INSTALL_DIR)/include/` for generating gen-cpp2 for carbon_result.thrift.
Tupperware is the internal tool of Meta, so guarding it out in order to fix OSS build failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
D89334763 introduced the use of
include "thrift/annotation/thrift.thrift"incarbon_result.thrift.This should be fixed by
-I $(INSTALL_DIR)/include/for generating gen-cpp2 for carbon_result.thrift.D89393569 exposed the component of Tupperware which is a Meta-only tool, so guarding the section related to TW with MCROUTER_OSS_BUILD to fix the issue for OSS build.