Conversation
|
@amyworrall has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@amyworrall has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| static let strikethrough = StyleName(rawValue: "strikethrough") | ||
| static let code = StyleName(rawValue: "code") | ||
| static let superScript = StyleName(rawValue: "superScript") | ||
| static let subScript = StyleName(rawValue: "subScript") |
There was a problem hiding this comment.
I'm not sure what's the benefit of declaring these as constants in a struct. Is it to allow plugins to register their own styles (for extensibility)?
might be worth considering an enum:
enum Style: String, Codable {
case bold
case italic
...
case subScript = "subScript"
}
or if we need this to be extensible then:
enum Style: Codable {
case bold
case italic
case custom(String) // can be extended by plugins
init(from decoder: Decoder) throws {
// manual decoding
}
}
``
There was a problem hiding this comment.
The pattern I've used here is
I'm not sure what's the benefit of declaring these as constants in a struct. Is it to allow plugins to register their own styles (for extensibility)?
The pattern I've used here is the same as used for NodeType, etc…
I rather wanted to place all styles on equal footing, without favouring the built-in ones over whatever is added by a plugin…
|
Hi @amyworrall! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
3 participants
[Work in progress] new styles system