Use a single type for TextFormatType everywhere and use set operation…#52
Open
mansimransingh wants to merge 1 commit intofacebook:mainfrom
Open
Use a single type for TextFormatType everywhere and use set operation…#52mansimransingh wants to merge 1 commit intofacebook:mainfrom
mansimransingh wants to merge 1 commit intofacebook:mainfrom
Conversation
mansimransingh
changed the title
Contributor
|
Hi! Happy to merge this, once I've had time to update our internal stuff to be compatible. You might be interested in my proposed new styles system (PR #46). It's a rethink of text styles, to make them extensible, type-safe, and more. The idea is that we bring this to both iOS and web, replacing the TextFormat and Style fields on both platforms. I've got an initial iOS implementation in that PR (subject to a couple of things on my to-do list, but it's essentially functioning). We need to decide on a path to shipping it, especially in terms of backwards compatibility, and whether we wait for web to build it and ship both at the same time. I'd welcome your thoughts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting confused with having multiple types for TextFormat and having to convert between them. So i refactored to use a single TextFormatType as an OptionSet and using set operations where possible.
Happy to discuss. Just trying to reduce the number of types lexical declares and converting between them.