fix(interpreter): expand assoc array keys with command substitutions#878
Merged
fix(interpreter): expand assoc array keys with command substitutions#878
Conversation
Add async expand_assoc_key() that uses full word expansion (parse_word_string + expand_word) for associative array keys containing $() or backtick substitutions. Replaces the sync-only expand_variable_or_literal() call in process_command_assignments(). Fixes #872
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expand_assoc_key()that uses full word expansion (parse_word_string+expand_word) for associative array keys containing$()or backtick substitutionsexpand_variable_or_literal()call inprocess_command_assignments(), which could only handle$var/${var}but not command substitutionsFixes #872
Test plan
assoc_key_command_substitution—m["$(echo hello)"]="world"expands key tohelloassoc_key_variable_expansion—m[$key]still worksassoc_key_literal_unchanged— bare literal keys unchanged