Merged
Conversation
- Update spec test counts: 2278→2463 total (1809→1939 bash, 75→78 sed, 116→121 jq, 57→60 python, add 44 typescript) - Add 21 new test files to bash spec breakdown - Fix builtin count: 147+3→148+8=156 (add numfmt, fix feature-gated count) - Update threat count: 60+→250+ in README - Update exec status: partially implemented (fd redirects, command exec) - Add AWK safety limits section and curl security mitigations to spec - Extract shared MAX_FORMAT_WIDTH constant (printf + awk deduplication) - Populate [Unreleased] CHANGELOG with 45 entries since v0.1.14
chaliy
added a commit
that referenced
this pull request
Apr 6, 2026
The maintenance pass (PR #1063) shipped while CI on main was red for 9 days and fuzz had 5 failures. Root causes: - Spec only required nightly/fuzz green, not CI on main - Maintain skill only checked nightly.yml and fuzz.yml, missing ci.yml - No language marking the check as a blocker that prevents merging Changes: - Rename "Nightly CI" → "CI Health", add "CI on main is green" check - Mark the section as a hard gate — pass cannot complete while red - Expand escalation policy to cover all workflows, not just nightly - Update maintain skill with concrete `gh` commands for CI on main - Add "never silently skip" instruction for the agent Ref: #1088 #1089 #1090 #1091
3 tasks
yonas
pushed a commit
to yonasBSD/bashkit
that referenced
this pull request
Apr 7, 2026
…erruns#1092) ## Summary - Rename "Nightly CI" → "CI Health" in maintenance spec and skill - Add "CI on main is green" as a required check (was missing — only nightly/fuzz were checked) - Mark the section as a **hard gate** — maintenance pass cannot complete while red - Expand escalation policy to cover all workflows (CI, nightly, fuzz) - Add concrete `gh` commands for inspecting CI on main to the maintain skill - Add "never silently skip" instruction for the agent ## Context The maintenance pass (PR everruns#1063, Apr 5) shipped while: - CI on main was red for 9 days (`cargo vet` missing `fastrand:2.4.0` cert, everruns#1091) - Fuzz had 5 failures across 3 distinct bugs (everruns#1088, everruns#1089, everruns#1090) Root cause: the spec and skill only checked nightly/fuzz workflows, not the main CI workflow, and had no hard-gate language preventing merge while red. ## Test plan - [x] Spec changes are documentation-only, no code impact - [x] Verify maintain skill section 10 now covers CI on main, nightly, and fuzz - [x] Verify escalation policy applies to all three workflow types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_FORMAT_WIDTHconstant from duplicated printf/awk definitionsnumfmtto builtin list (was missing from spec)Test plan
cargo check --all-featurespassescargo clippy --all-targets --all-features -- -D warningscleancargo test --all-featuresall passcargo fmt --checkcleancargo deny checkpassescargo outdated— all deps current