Skip to content

chore(specs): make CI health a hard gate in maintenance checklist#1092

Merged
chaliy merged 4 commits intomainfrom
claude/check-ci-errors-1P7dg
Apr 6, 2026
Merged

chore(specs): make CI health a hard gate in maintenance checklist#1092
chaliy merged 4 commits intomainfrom
claude/check-ci-errors-1P7dg

Conversation

@chaliy
Copy link
Copy Markdown
Contributor

@chaliy chaliy commented Apr 6, 2026

Summary

  • Rename "Nightly CI" → "CI Health" in maintenance spec and skill
  • Add "CI on main is green" as a required check (was missing — only nightly/fuzz were checked)
  • Mark the section as a hard gate — maintenance pass cannot complete while red
  • Expand escalation policy to cover all workflows (CI, nightly, fuzz)
  • Add concrete gh commands for inspecting CI on main to the maintain skill
  • Add "never silently skip" instruction for the agent

Context

The maintenance pass (PR #1063, Apr 5) shipped while:

Root cause: the spec and skill only checked nightly/fuzz workflows, not the main CI workflow, and had no hard-gate language preventing merge while red.

Test plan

  • Spec changes are documentation-only, no code impact
  • Verify maintain skill section 10 now covers CI on main, nightly, and fuzz
  • Verify escalation policy applies to all three workflow types

chaliy added 4 commits April 6, 2026 03:39
The maintenance pass (PR #1063) shipped while CI on main was red for 9
days and fuzz had 5 failures. Root causes:

- Spec only required nightly/fuzz green, not CI on main
- Maintain skill only checked nightly.yml and fuzz.yml, missing ci.yml
- No language marking the check as a blocker that prevents merging

Changes:
- Rename "Nightly CI" → "CI Health", add "CI on main is green" check
- Mark the section as a hard gate — pass cannot complete while red
- Expand escalation policy to cover all workflows, not just nightly
- Update maintain skill with concrete `gh` commands for CI on main
- Add "never silently skip" instruction for the agent

Ref: #1088 #1089 #1090 #1091
The Audit CI job has been failing since Mar 28 because cargo-vet could
not verify fastrand:2.4.0. The exemption existed but was insufficient
when cargo-vet fetched remote registry data in CI (locally it passed
due to TLS certificate issues skipping remote fetches).

Add an explicit audit entry and remove the redundant exemption.

Fixes #1091
@chaliy chaliy merged commit 46bfbfa into main Apr 6, 2026
11 checks passed
@chaliy chaliy deleted the claude/check-ci-errors-1P7dg branch April 6, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant