Contribution #1
Open
Contribution #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Effect measures
…00 char. This has prevented a bug once before but I couldn't reproduce it, hence the comment
…any function using ReporteRs now checks if the package is installed)
…nstance). Added some dummy tests (with thesthat package). Some minor refactorings
…, cleaned files names
Clarified message for effects (with warning)
removed "pvalue=" is showmethod=F
Improved formatting for moystd, mediqr, minmax and nna; Optimized the help file too.
fixed NAMESPACE, update manuals, cleaned some roxygen, defaulting project to UTF-8, improved testthat tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi David,
Long time no see!
I've been working a lot with your great package and I finally took the time to commit nearly all my tweaks.
I removed the
ReporteRsdependency so thatbiostats2is no longer dependant onrJavawhich caused quite a few bugs on some computers. The package is still backward-compatible though, it just doesn't force theReporteRsinstallation anymore.I only added 3 sugar practical function for working with
officer:body_add_crosstable,body_add_normalandbody_add_title, but maybe there should be more of them.I also exported the
compactfunction which could be very useful too in aRmdor aXaringanpresentation.Finally, I added some dummy tests.
Hope this can help.
See you
Dan