Skip to content

Add audit details page and audit tracing#28

Merged
mrferris merged 4 commits intoethereum:masterfrom
mrferris:query-trace
Apr 27, 2023
Merged

Add audit details page and audit tracing#28
mrferris merged 4 commits intoethereum:masterfrom
mrferris:query-trace

Conversation

@mrferris
Copy link
Contributor

@mrferris mrferris commented Dec 21, 2022

This PR adds a string column to the contentaudit schema, and renders the query graph on the audit details page for audits that have traces.

Screen Shot 2023-01-04 at 1 08 54 PM

todo:

  • Add query stats to audit details page
  • Add table view of nodes next to graph view
  • Get rid of 13k line diff to bootstrap.min.css

@mrferris mrferris changed the title WIP: Adds query tracing and audit details page on which to view query traces WIP: Adds query tracing and audit details page on which to view audit traces Dec 21, 2022
@mrferris mrferris changed the title WIP: Adds query tracing and audit details page on which to view audit traces WIP: Add audit details page and audit tracing Dec 21, 2022
@mrferris mrferris mentioned this pull request Jan 4, 2023
6 tasks
@mrferris mrferris changed the title WIP: Add audit details page and audit tracing Add audit details page and audit tracing Mar 20, 2023
@mrferris mrferris force-pushed the query-trace branch 3 times, most recently from a95d563 to 4c40bb4 Compare March 24, 2023 04:14
@mrferris mrferris self-assigned this Apr 13, 2023
@mrferris mrferris marked this pull request as ready for review April 20, 2023 22:14
@mrferris mrferris force-pushed the query-trace branch 2 times, most recently from c9c174d to e0c902a Compare April 26, 2023 17:28
@mrferris
Copy link
Contributor Author

@pipermerriam When you have a second mind quickly reviewing this? The DB migration is the main thing that will affect anything else.

I've updated this to not call the Trace endpoint, so trace columns in the DB will be empty and things will looks the same.

Once we merge #110 we'll know on the fly whether a given client supports the Trace endpoint and if so we'll populate the trace field and the functionality in this PR will link & display the query's trace.

@mrferris mrferris requested a review from pipermerriam April 26, 2023 19:35
Copy link
Member

@pipermerriam pipermerriam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrferris mrferris merged commit 0ffea22 into ethereum:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants