Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the visualization capabilities of the MPPI controller. It provides granular control over what aspects of the controller's operation are visualized, from individual trajectory costs to the robot's footprint along the chosen path. This enhancement aims to offer developers and users a clearer understanding of the controller's behavior and performance, facilitating debugging and tuning. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the MPPI controller's visualization system by introducing a new Visualization parameter namespace in nav2_params.yaml and consolidating all visualization logic into a dedicated TrajectoryVisualizer class. The changes include adding new parameters for publishing various trajectory data (total costs, individual critic costs, optimal footprints, optimal trajectory messages, and optimal paths) and removing older, less granular visualization flags. The MPPIController now uses a single visualize call on the TrajectoryVisualizer, passing all necessary data. CriticData is extended to store individual critic costs, and CriticManager is updated to populate these costs when visualize_per_critic_costs is enabled. Additionally, individual critics (PathAlignCritic, PathAngleCritic, PathFollowCritic) gain the ability to visualize their furthest reached path points. A review comment highlights a bug where a new test, VisPathRepub, was added for publish_transformed_path, but the corresponding publishing logic was not implemented, causing the test to fail.
There is still a bug that the publish_trajectories_with_individual_cost doesn't update on reconfigure calls
Add MPPI visualization based on ros-navigation#5643
Note: This is a cherry-pick of a PR which was stopped mid-progress. It works wel but may not be the cleanest.
Note 2: Recentely, another vis PR was merged, but using a slightly different method and missing the visualization of
furthest_reachedpoint for critics. Considering the current code is ok for us, and the merged PR is missing the most useful feature, I decided to use this version, and reconsider in the next rebase on upstream,