-
Notifications
You must be signed in to change notification settings - Fork 5.3k
api: add internal listener #15376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add internal listener #15376
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,7 +35,7 @@ message ListenerCollection { | |
| repeated xds.core.v3.CollectionEntry entries = 1; | ||
| } | ||
|
|
||
| // [#next-free-field: 27] | ||
| // [#next-free-field: 28] | ||
| message Listener { | ||
| option (udpa.annotations.versioning).previous_message_type = "envoy.api.v2.Listener"; | ||
|
|
||
|
|
@@ -88,6 +88,11 @@ message Listener { | |
| } | ||
| } | ||
|
|
||
| // Configuration for envoy internal listener. All the future internal listener features should be added here. | ||
| // [#not-implemented-hide:] | ||
| message InternalListenerConfig { | ||
| } | ||
|
|
||
| reserved 14; | ||
|
|
||
| // The unique name by which this listener is known. If no name is provided, | ||
|
|
@@ -275,4 +280,26 @@ message Listener { | |
| // :ref:`use_original_dst <envoy_api_field_config.listener.v3.Listener.use_original_dst>` | ||
| // to true. Default is true. | ||
| google.protobuf.BoolValue bind_to_port = 26; | ||
|
|
||
| // The exclusive listener type and the corresponding config. | ||
| // TODO(lambdai): https://github.com/envoyproxy/envoy/issues/15372 | ||
| // Will create and add TcpListenerConfig. Will add UdpListenerConfig and ApiListener. | ||
| // [#not-implemented-hide:] | ||
| oneof listener_specifier { | ||
| // Used to represent an internal listener which does not listen on OSI L4 address but can be used by the | ||
| // :ref:`envoy cluster <envoy_v3_api_msg_config.cluster.v3.Cluster>` to create a user space connection to. | ||
| // The internal listener acts as a tcp listener. It supports listener filters and network filter chains. | ||
| // The internal listener require :ref:`address <envoy_api_field_config.listener.v3.Listener.address>` has | ||
| // field `envoy_internal_address`. | ||
| // | ||
| // There are some limitations are derived from the implementation. The known limitations include | ||
| // | ||
| // * :ref:`ConnectionBalanceConfig <envoy_api_msg_config.listener.v3.Listener.ConnectionBalanceConfig>` is not | ||
| // allowed because both cluster connection and listener connection must be owned by the same dispatcher. | ||
| // * :ref:`tcp_backlog_size <envoy_api_field_config.listener.v3.Listener.tcp_backlog_size>` | ||
| // * :ref:`freebind <envoy_api_field_config.listener.v3.Listener.freebind>` | ||
| // * :ref:`transparent <envoy_api_field_config.listener.v3.Listener.transparent>` | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do internal listeners support passing additional metadata from source? This would be interesting to be able to propagate filter metadata or filter state without the wire encoding.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's a good question. |
||
| // [#not-implemented-hide:] | ||
| InternalListenerConfig internal_listener = 27; | ||
| } | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.