api: add internal listener#15376
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
The WIP implementation can be found in lambdai#11 |
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks, exciting to see this moving along.
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks LGTM with a small comment.
/wait
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
/retest |
|
Retrying Azure Pipelines: |
| // allowed because both cluster connection and listener connection must be owned by the same dispatcher. | ||
| // * :ref:`tcp_backlog_size <envoy_api_field_config.listener.v3.Listener.tcp_backlog_size>` | ||
| // * :ref:`freebind <envoy_api_field_config.listener.v3.Listener.freebind>` | ||
| // * :ref:`transparent <envoy_api_field_config.listener.v3.Listener.transparent>` |
There was a problem hiding this comment.
Do internal listeners support passing additional metadata from source? This would be interesting to be able to propagate filter metadata or filter state without the wire encoding.
There was a problem hiding this comment.
That's a good question.
Let me complete the doc and share it with you. It's easy to implement but it's hard to utilize such ability. The api will be weird if the proportion only work with internal connection
Signed-off-by: Yuchen Dai <silentdai@gmail.com> Signed-off-by: Auni Ahsan <auni@google.com>
5 participants
Commit Message:
Add listener type
internal listenerSigned-off-by: Yuchen Dai silentdai@gmail.com
Additional Description:
Discussed #11725
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]