Skip to content

Migrate to platform APIs #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daniel-k merged 1 commit into from
May 13, 2025
Merged

Migrate to platform APIs #54

daniel-k merged 1 commit into from
May 13, 2025

Conversation

@daniel-k
Copy link
Member

@daniel-k daniel-k commented May 13, 2025

Reapplies #47

@github-actions
Copy link

github-actions bot commented May 13, 2025

Coverage results

This is the coverage report for commit d3ba333

Name                                                               Stmts   Miss  Cover   Missing
------------------------------------------------------------------------------------------------
.tox/py/lib/python3.12/site-packages/enlyze/__init__.py                4      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_client/client.py      65      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_client/models.py      85      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/auth.py                   13      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/client.py                105      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/constants.py               7      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/errors.py                  4      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/iterable_tools.py          7      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/models.py                117      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/schema.py                 25      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/validators.py             38      0   100%
------------------------------------------------------------------------------------------------
TOTAL                                                                470      0   100%

2 empty files skipped.

@daniel-k daniel-k mentioned this pull request May 13, 2025
Merged
@daniel-k daniel-k marked this pull request as ready for review May 13, 2025 11:54
@daniel-k daniel-k requested a review from denizs May 13, 2025 11:54
@daniel-k daniel-k merged commit 79d844d into master May 13, 2025
12 checks passed
@daniel-k daniel-k deleted the feature/migrate-platform-api branch May 13, 2025 13:52
daniel-k added a commit that referenced this pull request May 13, 2025
@daniel-k
Fixes for migration to platform APIs v2 (#55)
afb16b8 
This PR fixes issues we overlooked when merging #47. It depends on #54
so that we can review the fixes in isolation and don't get distracted
with code that has already been approved.

- remove `Site.address`: we don't publish this property anymore since
`v2`
- refactor `get_timeseries()` to use `POST` with slightly changed schema
in `v2`

Closes #45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denizs denizs denizs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daniel-k @denizs