-
Notifications
You must be signed in to change notification settings - Fork 0
Fixes for migration to platform APIs v2 #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reapplies #47
10d10b7 to
b4d9eec
Compare
b4d9eec to
ca63d20
Compare
Coverage resultsUpdate on 2025-05-13 13:56:07.318979885 +0000 This is the coverage report for commit fee1071 |
Closed
denizs
requested changes
May 13, 2025
denizs
approved these changes
May 13, 2025
Member
denizs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thans for addressing my changes 🎉
denizs
previously approved these changes
May 13, 2025
denizs
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues we overlooked when merging #47. It depends on #54 so that we can review the fixes in isolation and don't get distracted with code that has already been approved.
Site.address: we don't publish this property anymore sincev2get_timeseries()to usePOSTwith slightly changed schema inv2Closes #45
Depends on
Merge #54 first, then retarget this PR to
masterand merge right after.