Skip to content

Conversation

@daniel-k
Copy link
Member

@daniel-k daniel-k commented May 13, 2025

This PR fixes issues we overlooked when merging #47. It depends on #54 so that we can review the fixes in isolation and don't get distracted with code that has already been approved.

  • remove Site.address: we don't publish this property anymore since v2
  • refactor get_timeseries() to use POST with slightly changed schema in v2

Closes #45

Depends on

Merge #54 first, then retarget this PR to master and merge right after.

@daniel-k daniel-k force-pushed the feature/use-v2-api-reloaded branch from 10d10b7 to b4d9eec Compare May 13, 2025 10:31
@daniel-k daniel-k force-pushed the feature/use-v2-api-reloaded branch from b4d9eec to ca63d20 Compare May 13, 2025 10:33
@github-actions
Copy link

github-actions bot commented May 13, 2025

Coverage results

Update on 2025-05-13 13:56:07.318979885 +0000

This is the coverage report for commit fee1071

Name                                                               Stmts   Miss  Cover   Missing
------------------------------------------------------------------------------------------------
.tox/py/lib/python3.12/site-packages/enlyze/__init__.py                4      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_client/client.py      82      1    99%   143
.tox/py/lib/python3.12/site-packages/enlyze/api_client/models.py      84      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/auth.py                   13      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/client.py                 99      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/constants.py               6      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/errors.py                  4      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/iterable_tools.py          7      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/models.py                116      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/schema.py                 25      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/validators.py             38      0   100%
------------------------------------------------------------------------------------------------
TOTAL                                                                478      1    99%

2 empty files skipped.

@daniel-k daniel-k linked an issue May 13, 2025 that may be closed by this pull request
@daniel-k daniel-k requested a review from denizs May 13, 2025 11:53
@daniel-k daniel-k marked this pull request as ready for review May 13, 2025 11:53
@daniel-k daniel-k requested a review from denizs May 13, 2025 13:16
Copy link
Member

@denizs denizs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thans for addressing my changes 🎉

denizs
denizs previously approved these changes May 13, 2025
Base automatically changed from feature/migrate-platform-api to master May 13, 2025 13:52
@daniel-k daniel-k dismissed denizs’s stale review May 13, 2025 13:52

The base branch was changed.

@daniel-k daniel-k requested a review from denizs May 13, 2025 14:00
@daniel-k daniel-k merged commit afb16b8 into master May 13, 2025
12 checks passed
@daniel-k daniel-k deleted the feature/use-v2-api-reloaded branch May 13, 2025 14:05
daniel-k added a commit that referenced this pull request May 26, 2025
In both #47 and #55 we have missed breaking changes in the production
runs endpoint of the v2 API:

- production runs don't contain the product resource anymore, but only a
reference (UUID)
- product and production order "code" was renamed to "external id"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to /api/v2

3 participants