Skip to content

Fix SendMatrices not uploading any data to shader uniform #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smeas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix SendMatrices not uploading any data to shader uniform #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions c_api_src/wrap_love_dll.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6057,15 +6057,26 @@ namespace wrap
return false;
}

if (matrix_count <= 0)
{
wrap_ee("no matrix was supplied for uniform variable '%s'", name);
return false;
}

int columns = info->matrix.columns;
int rows = info->matrix.rows;
if (columns_lenght != columns || rows_length != rows_length)
if (columns_lenght != columns || rows_length != rows)
{
wrap_ee("matrix columns or rows error, uniform variable %s send type error", name);
return false;
}

int count = inline_type_Shader_getCount(info, matrix_count);
int count = inline_type_Shader_getCount(info, matrix_count);
int components = rows * columns;
float* values = info->floats;

memcpy(values, valueArray, components * count * sizeof(float));

return wrap_catchexcept([&]() { shader->updateUniform(info, count); });
}

Expand Down