Fix SendMatrices not uploading any data to shader uniform#119
Open
smeas wants to merge 1 commit intoendlesstravel:masterfrom
Open
Fix SendMatrices not uploading any data to shader uniform#119smeas wants to merge 1 commit intoendlesstravel:masterfrom
smeas wants to merge 1 commit intoendlesstravel:masterfrom
Conversation
- Fixed sendMatrices to copy the matrices data properly before updating the uniform - Fixed typo in matrix size guard - Added safety check for zero sized array input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SendMatrices did not copy any data to the shader uniform info structure, leading to it always setting the shader uniforms to zero.
Changes