Skip to content

feat: add eloq_store_max_global_request_batch and update submodule #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thweetkomputer wants to merge 5 commits into
base: main
Choose a base branch
from
+4 −1
Open

feat: add eloq_store_max_global_request_batch and update submodule #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9ec126
update
thweetkomputer Mar 18, 2026
81589cf
update
thweetkomputer Mar 18, 2026
c8cc41e
update
thweetkomputer Mar 18, 2026
fb8c7ed
update
thweetkomputer Mar 18, 2026
4b87fc1
fix
thweetkomputer Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data_substrate
Open in desktop
Submodule data_substrate updated 6 files
+1 −1 store_handler/eloq_data_store_service/data_store.h
+1 −1 store_handler/eloq_data_store_service/data_store_service.cpp
+11 −0 store_handler/eloq_data_store_service/eloq_store_config.cpp
+3 −2 store_handler/eloq_data_store_service/eloq_store_data_store.h
+1 −1 store_handler/eloq_data_store_service/eloqstore
+11 −1 tx_service/src/remote/cc_node_service.cpp
3 changes: 3 additions & 0 deletions eloqkv.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,9 @@ node_group_replica_num = 1
# [CLOUD OPTIONAL] Reuse existing local files when restoring from cloud.
# eloq_store_reuse_local_files=false

# Maximum number of requests EloqStore processes in one global batch.
# eloq_store_max_global_request_batch=1000
Comment on lines +176 to +177
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# 1) Find all references to the new config key.
rg -n --hidden -S '\beloq_store_max_global_request_batch\b'

# 2) Inspect INI-read paths and flag conversion/mapping points.
rg -n --hidden -S 'INIReader|ConvertEloqkvFlagsToTxFlags|GetInteger|GetBoolean|GetReal|Get\(' src

# 3) If a config struct/flag exists, verify mapping into runtime/store options.
rg -n --hidden -S 'max_global_request_batch|global_request_batch|request_batch' src data_substrate

Repository: eloqdata/eloqkv

Length of output: 3845

Remove or wire this INI key—it is not consumed by any code.

The documented config option eloq_store_max_global_request_batch exists only as a comment in lines 176–177 of eloqkv.ini. A full repository search found zero references to this key outside the INI file. It is never parsed or propagated to any runtime configuration, making it a misleading no-op setting that serves no operational purpose. Either remove this documentation, or implement the parsing and propagation logic to actually use it in EloqStore initialization.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@eloqkv.ini` around lines 176 - 177, The commented INI key
eloq_store_max_global_request_batch is not consumed by code; either remove it
from eloqkv.ini or wire it into the runtime: add the key to the configuration
schema (e.g., AppConfig or Config type used by loadConfig/parseIni), parse it
from eloqkv.ini (use the existing loadConfig/parseIni function), provide a
sensible default (e.g., 1000), and pass the value into EloqStore
construction/initialization (EloqStore constructor or createEloqStore factory)
so the batching logic (methods like processBatch or wherever batching occurs)
uses this maxGlobalRequestBatch value. Ensure the symbol
eloq_store_max_global_request_batch is referenced consistently in config
parsing, AppConfig, and the EloqStore initialization path.


# Maximum number of concurrent standby rsync/ssh jobs managed by EloqStore.
# eloq_store_standby_max_concurrency=100

Expand Down
Loading