feat: add eloq_store_max_global_request_batch and update submodule #457
feat: add eloq_store_max_global_request_batch and update submodule #457thweetkomputer wants to merge 5 commits intoeloqdata:mainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughSubmodule Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@data_substrate`:
- Line 1: The submodule pointer for "data_substrate" references a non-existent
commit (560ce10b762d2e597ea19afebc8ecffa7a48367b); verify that the commit hash
is correct in the remote `tx_service` repo and that the commit has been pushed,
and if not, push the missing commit or update the submodule pointer: either push
the referenced commit to the remote repo or update the submodule reference in
.gitmodules (and the gitlink in the parent repo) to a valid existing commit for
the `data_substrate` submodule, then run the appropriate git submodule
update/init commands and commit the corrected submodule state.
In `@eloqkv.ini`:
- Around line 176-177: The commented INI key eloq_store_max_global_request_batch
is not consumed by code; either remove it from eloqkv.ini or wire it into the
runtime: add the key to the configuration schema (e.g., AppConfig or Config type
used by loadConfig/parseIni), parse it from eloqkv.ini (use the existing
loadConfig/parseIni function), provide a sensible default (e.g., 1000), and pass
the value into EloqStore construction/initialization (EloqStore constructor or
createEloqStore factory) so the batching logic (methods like processBatch or
wherever batching occurs) uses this maxGlobalRequestBatch value. Ensure the
symbol eloq_store_max_global_request_batch is referenced consistently in config
parsing, AppConfig, and the EloqStore initialization path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 567f1c64-3ef7-405d-b8b3-fe3629ac704b
📒 Files selected for processing (2)
data_substrateeloqkv.ini
| # Maximum number of requests EloqStore processes in one global batch. | ||
| # eloq_store_max_global_request_batch=1000 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# 1) Find all references to the new config key.
rg -n --hidden -S '\beloq_store_max_global_request_batch\b'
# 2) Inspect INI-read paths and flag conversion/mapping points.
rg -n --hidden -S 'INIReader|ConvertEloqkvFlagsToTxFlags|GetInteger|GetBoolean|GetReal|Get\(' src
# 3) If a config struct/flag exists, verify mapping into runtime/store options.
rg -n --hidden -S 'max_global_request_batch|global_request_batch|request_batch' src data_substrateRepository: eloqdata/eloqkv
Length of output: 3845
Remove or wire this INI key—it is not consumed by any code.
The documented config option eloq_store_max_global_request_batch exists only as a comment in lines 176–177 of eloqkv.ini. A full repository search found zero references to this key outside the INI file. It is never parsed or propagated to any runtime configuration, making it a misleading no-op setting that serves no operational purpose. Either remove this documentation, or implement the parsing and propagation logic to actually use it in EloqStore initialization.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@eloqkv.ini` around lines 176 - 177, The commented INI key
eloq_store_max_global_request_batch is not consumed by code; either remove it
from eloqkv.ini or wire it into the runtime: add the key to the configuration
schema (e.g., AppConfig or Config type used by loadConfig/parseIni), parse it
from eloqkv.ini (use the existing loadConfig/parseIni function), provide a
sensible default (e.g., 1000), and pass the value into EloqStore
construction/initialization (EloqStore constructor or createEloqStore factory)
so the batching logic (methods like processBatch or wherever batching occurs)
uses this maxGlobalRequestBatch value. Ensure the symbol
eloq_store_max_global_request_batch is referenced consistently in config
parsing, AppConfig, and the EloqStore initialization path.
1 participant
Summary by CodeRabbit