Send feedback on uninstall #2394
Conversation
|
What do you think about sending the signal directly in the flatpak backend? And eventually doing the same for installed? |
|
@leolost2605 yeah when I was doing this it felt extremely convoluted and messy. Do you want me to refactor first? |
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
Should we maybe DRY this a bit? E.g. change the mainwindow.send_installed_toast to send_toast and have it take the performed package op as an argument. Then we could also unify the checking for the window active etc.
danirabbit
force-pushed
the
danirabbit/uninstall-feedback
branch
from
051eae8 to
32224ec
Compare
Fix notification body text DRY toast sending Add user feedback issue to appcenter metadata
danirabbit
force-pushed
the
danirabbit/uninstall-feedback
branch
from
32224ec to
f147f89
Compare
|
@leolost2605 fixed and proposed #2398 for merging after this with some more cleanup |
|
@leolost2605 can I get a re-review? Is it okay to do things in this order or should I break out that stuff in |
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
I think it's fine. Cleanup is a never ending story so let's not get held up on it too much (e.g. we could also look into merging installfaileddialog and uninstallfaileddialog since they are very similar before breaking out the error checking to remove another switch, etc.) 😅
LGTM!
Fixes #2393