Skip to content

Package: combine single-use methods, always signal operation finished #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danirabbit merged 3 commits into from
Jan 27, 2026
Merged

Package: combine single-use methods, always signal operation finished #2397

danirabbit merged 3 commits into from
Jan 27, 2026
+23 −42

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 23, 2026 •
edited
Loading

We can definitely go further with refactoring, but wanted to stop before it got too complicated while also DRYing for #2394

  • Combines the single-use prepare and clean_up functions into perform_operation
  • Make sure we always send operation_finished in perform operation
  • Fix early returns and throw errors

@danirabbit danirabbit requested a review from a team January 26, 2026 18:20
leolost2605
leolost2605 approved these changes Jan 27, 2026
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@danirabbit danirabbit merged commit a606855 into main Jan 27, 2026
4 checks passed
@danirabbit danirabbit deleted the danirabbit/package-refactor-packageop branch January 27, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leolost2605 leolost2605 leolost2605 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danirabbit @leolost2605