This repository was archived by the owner on Nov 29, 2022. It is now read-only.
refactor: migrate style processing to webpack#4765
Closed
nastushalk wants to merge 11 commits intoelectron:masterfrom
nastushalk:nl/webpack-styling
Closed
refactor: migrate style processing to webpack#4765nastushalk wants to merge 11 commits intoelectron:masterfrom nastushalk:nl/webpack-styling
nastushalk wants to merge 11 commits intoelectron:masterfrom
nastushalk:nl/webpack-styling
Conversation
Closed
erickzhao
approved these changes
Jan 26, 2021
feat: use webpack-dev-middleware feat: remove old browserify stuff 🤷♀️ chore: return removed things chore: try to fix build fix dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is do the final migration to the using webpack, by migrate making CSS. Also this PR switches the deprecated
node-sassto newsassmodule. This doesn't should break anything but something can happen.Fixes #4685