This repository was archived by the owner on Nov 29, 2022. It is now read-only.
build: use node 14#5047
Closed
vhashimotoo wants to merge 1 commit intoelectron:masterfrom
vhashimotoo:vh/node-14
Closed
build: use node 14#5047vhashimotoo wants to merge 1 commit intoelectron:masterfrom vhashimotoo:vh/node-14
vhashimotoo wants to merge 1 commit intoelectron:masterfrom
vhashimotoo:vh/node-14
Conversation
Merged
Contributor
|
Closed via #5274 Thanks @vhashimotoo ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 14 is LTS and everything "should" be good.
Why you shouldn't trust me?
Mostly because
node-sasscan break everything.node-sassis used in the two exemplars, one fromnode-sass@5.0.0and one fromnode-sass-middleware->node-sass@4.3.0and factically this means we should download two prebuild binaries. Theoretically and factically, this dependency is fixed by #4765.So I have prepared you, and on this, I end.