This repository was archived by the owner on Nov 29, 2022. It is now read-only.
refactor: migrate from browserify to webpack#4764
Merged
erickzhao merged 9 commits intoelectron:masterfrom Jan 8, 2021
nastushalk:vh/webpack
Merged
refactor: migrate from browserify to webpack#4764erickzhao merged 9 commits intoelectron:masterfrom nastushalk:vh/webpack
erickzhao merged 9 commits intoelectron:masterfrom
nastushalk:vh/webpack
Conversation
erickzhao
approved these changes
Jan 7, 2021
Member
erickzhao
left a comment
erickzhao
left a comment
There was a problem hiding this comment.
Seems to be running fine for me in both dev and prod!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is fully based on the #4319. For all information see him.
This PR updated finish the initial work of migrating to the webpack, the second part of the migrating is be using webpack to providing css, and potential fixing of #4685. webpack v5 not picked due to errors with using Node.js in frontend code.
Closes #4319