This repository was archived by the owner on Nov 29, 2022. It is now read-only.
refactor: migrate from browserify to webpack#4319
Closed
vhashimotoo wants to merge 8 commits intomasterfrom
Closed
refactor: migrate from browserify to webpack#4319vhashimotoo wants to merge 8 commits intomasterfrom
vhashimotoo wants to merge 8 commits intomasterfrom
Conversation
vhashimotoo
force-pushed
the
vh/webpack
branch
from
77effee to
be5cfaa
Compare
vhashimotoo
force-pushed
the
vh/webpack
branch
from
be5cfaa to
ebfa95f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, yes this is migration to webpack, why not.
Why
This contains a big history behind this what's starts from this comment: #2091 (comment), and that history continues to today day. Originally I'm unable to normally read the changelogs for
uglify-jsbecause them is empty, absolutely, check #4310 for example.Next thing is a precompiling script that looks very strange for modern folks. When you open this file and don't known what's you should change to make this thing work, what's stops on integrating new modern things.
That and more other reasons require me to make do this.
Differences
Mainly nothing changed, not for development, not for production, we still can use ES2020 features as before.
I'm not integrating
hot reload, since this is not a frontend framework. If we needhot reloadI'm an add she.Measurements
Build time:
Bundle size
I'm really not sure why the bundle size is so huge if you know webpack more than me, this is a bundle analyzer for the last build:
This is something that I will be monitoring in future PRs.
Future
This PR doesn't contain the code for building CSS file, this is being done in the next PR and on that this migration can be officially finished.