This repository was archived by the owner on Nov 29, 2022. It is now read-only.
Merged
Conversation
vhashimotoo
suggested changes
Feb 11, 2019
Contributor
vhashimotoo
left a comment
vhashimotoo
left a comment
There was a problem hiding this comment.
More questions going latest (maybe).
- How to verify if we load precompiled assets?
script/precompile-assets
Outdated
| @@ -0,0 +1,14 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
it's not the cross-platform able solution, what about the switch to Node for cross-platform running?
Contributor
Author
There was a problem hiding this comment.
That's a good idea. I'll do that today.
Kilian
approved these changes
Feb 12, 2019
Member
Kilian
left a comment
Kilian
left a comment
There was a problem hiding this comment.
I agree with @HashimotoYT that a node script would be easier. other than that 👍
Contributor
Author
|
I've updated the script to be in JavaScript; I was also able to save about 15% of the bundle size by modifying our lodash imports. |
vhashimotoo
approved these changes
Feb 14, 2019
Contributor
vhashimotoo
left a comment
vhashimotoo
left a comment
There was a problem hiding this comment.
🍏 for me. Only one proposal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we compile and serve JS and CSS from memory when those files are requested, resulting in significant delays for many requests. This PR implements precompilation for production mode.
Fixes #2084