Merged
Conversation
2 tasks
eikopf
force-pushed
the
worktree-twinkly-growing-valiant
branch
from
0f7ec92 to
12f8a1b
Compare
FieldPath is stored in every Blame value, making cheap clones important. Previously it was a plain Vec<PathSegment> requiring O(n) clones. This change salsa-interns FieldPath (making it Copy) by erasing the FieldName lifetime through salsa::Id storage in PathSegment. Blame also becomes Copy as both its fields are now salsa-interned. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Blame and FieldPath are now Copy, so replace .clone() calls with copies or field shorthand. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
eikopf
force-pushed
the
worktree-twinkly-growing-valiant
branch
from
566b8cb to
610b8ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FieldPathfor O(1) cloning and deduplication, replacing the plainVec<PathSegment>that required O(n) clones on everyBlamecopyFieldName<'db>lifetime by storingsalsa::IdinPathSegment, making the type'static-compatible for salsa interningCopyonBlamesince both fields (DeclId,FieldPath) are now salsa-internedSupersedes #84, which used
Rcwrapping instead.Test plan
cargo test --workspace)🤖 Generated with Claude Code