fix: wrap FieldPath inner Vec in Rc for O(1) cloning#84
Closed
Conversation
FieldPath values are frequently cloned when stored in Blame objects during record lowering. By wrapping the inner Vec<PathSegment> in Rc, clones become O(1) reference count bumps instead of O(n) vector copies. The push method now pre-allocates with exact capacity instead of clone + push, and the inner field is made private with a segments() accessor to maintain encapsulation. Closes #32 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
It's not clear to me that issue #32 is actually correct? I suspect it's being properly interned by |
1 task
Owner
Author
|
Superseded by #91 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FieldPath's innerVec<PathSegment>inRcso thatclone()is O(1) instead of O(n)segments()accessor for read accesspush()instead of clone + push.0field directly (eval.rstest andrender.rsdisplay impl)Test plan
cargo test --workspace)Closes #32
🤖 Generated with Claude Code