Skip to content

change min-width to auto #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yfdyh000 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change min-width to auto #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/static/css/options.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ body.version-lt-57 {
}
body[data-browser=Chrome] {
padding: 0 1em 1em 1em;
min-width: 520px;
min-width: auto;
Copy link
Copy Markdown
Owner

@eight04 eight04 Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to change it to:

width: 520px;
max-width: 100%;

Copy link
Copy Markdown
Contributor Author

@yfdyh000 yfdyh000 Feb 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that both min-width: auto; and max-width: 100%; can be omitted, and still achieve the same results in Chrome and Edge..

Copy link
Copy Markdown
Owner

@eight04 eight04 Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without max-width: 100%, the option page has a fixed width, resulting in horizontal scrollbar in Edge.

Copy link
Copy Markdown
Contributor Author

@yfdyh000 yfdyh000 Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the following styles look like they work for me in Edge, without horizontal scrollbar.
body[data-browser=Chrome] { padding: 0 1em 1em 1em; }

Copy link
Copy Markdown
Owner

@eight04 eight04 Feb 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but we also have to support Chrome and the default width is too small.

}

a {
Expand Down