Open
Conversation
eight04
requested changes
Feb 15, 2022
| body[data-browser=Chrome] { | ||
| padding: 0 1em 1em 1em; | ||
| min-width: 520px; | ||
| min-width: auto; |
Owner
There was a problem hiding this comment.
It might be better to change it to:
width: 520px;
max-width: 100%;
Contributor
Author
There was a problem hiding this comment.
It seems that both min-width: auto; and max-width: 100%; can be omitted, and still achieve the same results in Chrome and Edge..
Owner
There was a problem hiding this comment.
Without max-width: 100%, the option page has a fixed width, resulting in horizontal scrollbar in Edge.
Contributor
Author
There was a problem hiding this comment.
But the following styles look like they work for me in Edge, without horizontal scrollbar.
body[data-browser=Chrome] { padding: 0 1em 1em 1em; }
Owner
There was a problem hiding this comment.
Yes but we also have to support Chrome and the default width is too small.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that Edge 99 rejects such a wide options interface. There is no way to distinguish between Edge and Chrome.