feat: support load typescript file #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
code from: #21, fix lint error |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 5 5
Lines 185 185
=======================================
Hits 179 179
Misses 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
这 2 个 PR 的关系是？ 那边还有几个 Review 问题还没解决 |
Author
代码是一样的，只有一个 lint 问题修复了，但是看原作者好像没打算继续更新。 |
atian25
approved these changes
Jan 22, 2020
Member
|
@whxaxes 看下 |
Author
|
ping @whxaxes |
Member
|
补一下单测 |
whxaxes
reviewed
Mar 10, 2020
| } | ||
|
|
||
| if (stat.isFile() && path.extname(name) === '.js') { | ||
| if (stat.isFile() && [ '.js', '.ts' ].includes(path.extname(name))) { |
Member
There was a problem hiding this comment.
这里感觉有问题，如果项目下刚好同时存在同名的 .js 和 .ts 文件，但是又没有使用 ts-node ，下面的 require 就会出问题
whxaxes
reviewed
Mar 10, 2020
|
|
||
| if (stat.isFile() && path.extname(name) === '.js') { | ||
| if (stat.isFile() && [ '.js', '.ts' ].includes(path.extname(name))) { | ||
| let handler = require(filepath); |
Member
There was a problem hiding this comment.
这里直接 require 也会有问题，ts compile 出来的 js 是 esm ，模块内容是挂在 default 中的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change