Skip to content

Conversation

@zenghongtu
Copy link

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 requested a review from whxaxes June 25, 2019 06:04
lib/load_api.js Outdated
}

if (stat.isFile() && path.extname(name) === '.js') {
if (stat.isFile() && /\.(js|ts)$/.test(path.extname(name))) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe should use app.loader.loadFile(), cc @whxaxes

lib/load_api.js Outdated
}

if (stat.isFile() && path.extname(name) === '.js') {
if (stat.isFile() && /\.(js|ts)$/.test(path.extname(name))) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ '.js', '.ts' ].includes(path.extname(name)) seems better than regexp

@whxaxes
Copy link
Member

whxaxes commented Jul 4, 2019

any progress ?

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files           5        5           
  Lines         185      185           
=======================================
  Hits          179      179           
  Misses          6        6
Impacted Files Coverage Δ
lib/load_api.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf533ef...685d743. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files           5        5           
  Lines         185      185           
=======================================
  Hits          179      179           
  Misses          6        6
Impacted Files Coverage Δ
lib/load_api.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf533ef...685d743. Read the comment docs.

@zenghongtu
Copy link
Author

any progress ?

之前直接 install 我克隆的仓库,就把这个 pr 给忘了😂

@sabakugaara
Copy link

any progress ?

I create a new pr, fixed lint error, #23

@atian25 atian25 requested a review from whxaxes January 21, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants