Add flag to ignore the MigrationHistory table from the naming conventions#66
Add flag to ignore the MigrationHistory table from the naming conventions#66EraYaN wants to merge 1 commit intoefcore:mainfrom
Conversation
|
Please merge this! When I first apply the naming conventions extension, I am seeing: SELECT migration_id, product_version column "migration_id" does not exist |
|
@roji Thoughts? Is this a direction that might make it into the code base? |
7e62d57 to
5594847
Compare
|
Resolved the merge conflicts. |
5594847 to
b28a420
Compare
|
Made the tests make sense. |
|
@roji This is now properly ready I think |
|
I'll try to take a look at this in the coming week or two, thanks. |
|
Is it possible to merge this PR? Thanks in advance! |
dc8fe81 to
f92f02a
Compare
|
I have rebased this to the latest 7.0.0 version. |
|
I bumped into this exact issue, which is a very annoying problem. @roji any chance you could take a look at this PR and potentially approve running the workflows on the PR? Then we can get one step further toward a solution. |
|
Everyone, sorry I haven't been able to look at this PR (or the problem it attempts to fix). The 7.0 release is currently taking up most of my time, once things quiet down I'll try to look at this. Thanks for your patience. |
f92f02a to
51d67c4
Compare
|
I have rebased this to the latest 7.0.2 version. |
|
@roji Did you have a chance to take a look at this PR? |
51d67c4 to
9f0f118
Compare
dafa6dc to
0e961b3
Compare
|
Would it be possible to get this one in for the 8.0 version? @bricelam |
0e961b3 to
5e308db
Compare
|
I have rebased this for 8.0.2 on current |
5e308db to
4908075
Compare
|
Rebased this to 8.0.3 (current main) |
4908075 to
a222444
Compare
|
@steingran unfortunately there's not much chance I'll be able to find time for this in the near future. I traditionally do a concentrated spike of work near the end of the release, i.e. for EFCore.NamingConventions 9.0 - that should happen in a few months. I do promise to give this issue priority when I do... |
Is it possible to include this (.NET) 9.0 version? |
a222444 to
c4e5946
Compare
|
Rebased to 9.0.0 |
c4e5946 to
605e93a
Compare
|
Rebased to latest main |
605e93a to
cdab469
Compare
|
Resolved merge conflicts for .NET 10 and latest main changes. @roji Maybe this could make it in for v10? |
8c53c11 to
da9cb93
Compare
|
Rebased to latest master |
I put some tests in for now that should test the column names. (And the table name, but that doesn't change).
Not sure if this is the right way to go with the FullName test against a string, but it seems quite unlikely to have a name collision there.
Closes #1