Add parameter to ignore migration history table in UseSnakeCaseNamingConvention#313
Draft
Elgreen wants to merge 1 commit intoefcore:mainfrom
Draft
Add parameter to ignore migration history table in UseSnakeCaseNamingConvention#313Elgreen wants to merge 1 commit intoefcore:mainfrom
Elgreen wants to merge 1 commit intoefcore:mainfrom
Conversation
…Convention Add a parameter `ignoreMigrationHistoryTable` to `UseSnakeCaseNamingConvention()` to ignore columns in the `__EFMigrationsHistory` table. * Modify `UseSnakeCaseNamingConvention` method in `EFCore.NamingConventions/NamingConventionsExtensions.cs` to accept a new parameter `ignoreMigrationHistoryTable`. * Update `NamingConventionsOptionsExtension` class in `EFCore.NamingConventions/Internal/NamingConventionsOptionsExtension.cs` to include the `ignoreMigrationHistoryTable` parameter. * Add a new field `_ignoreMigrationHistoryTable` in `NameRewritingConvention` class in `EFCore.NamingConventions/Internal/NameRewritingConvention.cs` and update the constructor and `ProcessEntityTypeAdded` method to handle the new parameter. * Add a new test method `IgnoreMigrationHistoryTable` in `EFCore.NamingConventions.Test/IntegrationTest.cs` to test the `ignoreMigrationHistoryTable` parameter of the `UseSnakeCaseNamingConvention` method.
|
Any update on this PR? This is breaking the entire library now |
Member
|
How is it "breaking the entier library"? |
|
This might be a duplicate of #66 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a parameter
ignoreMigrationHistoryTabletoUseSnakeCaseNamingConvention()to ignore columns in the__EFMigrationsHistorytable.UseSnakeCaseNamingConventionmethod inEFCore.NamingConventions/NamingConventionsExtensions.csto accept a new parameterignoreMigrationHistoryTable.NamingConventionsOptionsExtensionclass inEFCore.NamingConventions/Internal/NamingConventionsOptionsExtension.csto include theignoreMigrationHistoryTableparameter._ignoreMigrationHistoryTableinNameRewritingConventionclass inEFCore.NamingConventions/Internal/NameRewritingConvention.csand update the constructor andProcessEntityTypeAddedmethod to handle the new parameter.IgnoreMigrationHistoryTableinEFCore.NamingConventions.Test/IntegrationTest.csto test theignoreMigrationHistoryTableparameter of theUseSnakeCaseNamingConventionmethod.