Skip to content

Conversation

@Akanshu-2u
Copy link
Contributor

@Akanshu-2u Akanshu-2u commented Dec 15, 2025

Description:

Partner retirement reports logged warnings for missing Points of Contact (POCs) but continued processing, creating compliance violations. Partners without POCs cannot be properly notified during learner retirement.

Solution:

  • Convert POC warnings to job failures with exit code ERR_MISSING_POC = -13
  • Add exempted_partners config for exemptions (e.g., "Expired" partners)
  • Include COMPLIANCE FAILURE messaging for Project Coordinator alerts

Implementation:

  • retirement_partner_report.py: Added compliance failure logic
  • helpers.py: Added exemption configuration support
  • Test files: Comprehensive coverage for all scenarios

Private JIRA Link:

BOMS-196

@Akanshu-2u Akanshu-2u marked this pull request as ready for review December 17, 2025 09:51
Copilot AI review requested due to automatic review settings December 17, 2025 09:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the partner retirement reporting process by converting Point of Contact (POC) warnings into compliance failures, ensuring proper notification of partners during learner retirement. The change addresses a compliance violation where partners without POCs could not be properly notified.

Key Changes:

  • Introduced ERR_MISSING_POC = -13 exit code for compliance failures when POCs are missing
  • Added partners_without_poc_required configuration option to exempt specific partners (e.g., expired/inactive partners) from POC requirements
  • Updated failure messaging to include "COMPLIANCE FAILURE" alerts for Project Coordinators

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.

File Description
tubular/scripts/retirement_partner_report.py Added ERR_MISSING_POC constant and compliance failure logic in _add_comments_to_files that fails the job when partners lack POCs unless exempt
tubular/scripts/helpers.py Added support for partners_without_poc_required configuration with Unicode normalization matching existing org_partner_mapping handling
tubular/tests/test_retirement_partner_report.py Updated test_successful_report to ensure all partners have POCs; added test_missing_poc_failure to verify compliance failures; added test_missing_poc_with_exemption to verify exemption logic works correctly
tubular/tests/retirement_helpers.py Extended fake_config_file helper to accept exempted_partners parameter for test configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 13, 2026 08:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Akanshu-2u Akanshu-2u merged commit 9f03aab into master Jan 13, 2026
9 checks passed
@Akanshu-2u Akanshu-2u deleted the aaich/BOMS-296 branch January 13, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants