feat: enhanced first notify for poc users and then fail for non-poc users

[Akanshu-2u]

Description:

When any partner was missing a POC, the job would fail immediately without notifying ANY partners - even those with valid POCs. This meant compliant partners were blocked by non-compliant partners' issues.

Solution:

Reordered the notification flow to notify compliant partners first, then fail:

• Partners with valid POCs receive their retirement reports immediately
• Only after successful notification does the job fail for missing POCs
• Maintains compliance alerting while preventing compliant partners from being blocked
• Technical team still gets alerted via Jenkins when job fails

Related PR:

• feat: Add support for exempt partners without POC in retirement reporting #49

Private JIRA Link:

BOMS-296

[Copilot]

Pull request overview

This pull request enhances the retirement partner report notification flow to ensure compliant partners (those with valid Points of Contact) receive their retirement reports even when other partners are missing POCs. Previously, the job would fail immediately upon detecting any partner with a missing POC, blocking notifications to all partners including compliant ones.

Changes:

• Reordered notification logic to notify compliant partners first, then fail for missing POCs
• Updated test to verify that partners with POCs receive notifications even when the job fails
• Maintains compliance alerting while preventing compliant partners from being blocked

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
tubular/scripts/retirement_partner_report.py	Moved notification block to execute before the compliance failure check, ensuring compliant partners are notified even when non-compliant partners cause job failure
tubular/tests/test_retirement_partner_report.py	Updated test_missing_poc_failure to add mock for create_comments_for_files and verify that partners with POCs are still notified before job fails

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.