chore: cleanup of mktg url link map #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sync before merging |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated MKTG_URL_LINK_MAP configuration variable from the edxapp configuration files as part of a cleanup effort tracked in ticket BOMS-215.
Key changes:
- Removal of
MKTG_URL_LINK_MAPconfiguration variable from all edxapp configuration files - The related
MKTG_URLSconfiguration remains intact
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| playbooks/roles/edxapp/defaults/main.yml | Removed EDXAPP_MKTG_URL_LINK_MAP default value and its reference in the generic environment configuration |
| docker/build/edxapp/studio.yml | Removed MKTG_URL_LINK_MAP from Studio configuration |
| docker/build/edxapp/lms.yml | Removed MKTG_URL_LINK_MAP from LMS configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ktyagiapphelix2u
added a commit
that referenced
this pull request
Nov 6, 2025
This reverts commit f860947.
ttak-apphelix
pushed a commit
that referenced
this pull request
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup of MKTG_URL_LINK_MAP from the repo
Ticket Link
https://2u-internal.atlassian.net/browse/BOMS-215