Revert "chore: cleanup of mktg url link map" #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f860947.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new configuration parameter MKTG_URL_LINK_MAP across edxapp configuration files to provide an additional mapping structure for marketing URL links, complementing the existing MKTG_URLS configuration.
Key Changes
- Added
MKTG_URL_LINK_MAPconfiguration parameter with an empty dictionary default value - Configured the new parameter in both Ansible playbook defaults and Docker build configurations
- Ensured consistent placement adjacent to the existing
MKTG_URLSparameter
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| playbooks/roles/edxapp/defaults/main.yml | Added EDXAPP_MKTG_URL_LINK_MAP default variable and mapped it to the environment configuration |
| docker/build/edxapp/studio.yml | Added MKTG_URL_LINK_MAP configuration parameter for Studio environment |
| docker/build/edxapp/lms.yml | Added MKTG_URL_LINK_MAP configuration parameter for LMS environment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ttak-apphelix
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #291