Strip down the version info from in script file#51
Open
usta wants to merge 1 commit intoedwardgeorge:masterfrom
Open
Strip down the version info from in script file#51usta wants to merge 1 commit intoedwardgeorge:masterfrom
usta wants to merge 1 commit intoedwardgeorge:masterfrom
Conversation
We will just use package version only defined in setup.py
eeshangarg
suggested changes
Jan 29, 2019
Contributor
eeshangarg
left a comment
eeshangarg
left a comment
There was a problem hiding this comment.
@usta: Thanks for working on this! Again, this looks fine but the commit message could be a bit better. I'd recommend Remove unnecessary __version__ declaration. (with the period at the end). :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will just use package version only defined in setup.py