Make setup py gets version from file#47
Conversation
I believe with this way it will be much suitable for version bumps. This PR also fixes a small bug about a typo in MANIFEST.in
|
@eeshangarg I assume you'll review (are you subscribed to notifications for this repo such that I don't need to mention you?) |
There was a problem hiding this comment.
@usta: Thanks for working on this! I tested this and it works.
Now that I think about it, the __version__ value is kinda useless. The only purpose it serves is printing an error message for when the script isn't given enough command-line arguments. For that, we don't really need the version number. And since the package is never really imported (it only has an executable), I can't imagine a scenario where a user may go import clonevirtualenv; clonevirtualenv.__version__, they can just use pip freeze if they want to find out the version. Is there a reason why a __version__ value might be useful for an executable-only package that I am not aware of? If not, we could honestly just get rid of it and that would make everything simpler.
Even some popular Python packages have a history of using "hacks" to store version numbers globally in an external file, so it isn't a big deal either way, but still worth a short discussion. :) Thanks!
| @@ -1,2 +1,2 @@ | |||
| include README | |||
| include README.md | |||
| include LICENSE | |||
There was a problem hiding this comment.
Could you please split this one out into a separate commit?
There was a problem hiding this comment.
Could you please split this one out into a separate commit?
Sure
|
@timabbott: yes, I just subscribed to alerts for this repo, so you don't have to explicitly mention me in issues/PRs anymore! Thanks! :) |
If you ask my opinion it will be much better we just have the version number in setup.py, not in other files. |
|
@eeshangarg @timabbott also I have stripped down the version info from script file so we just follow version in setup.py with : #51 |
|
@usta: Cool sounds good, I just reviewed your other PRs! :) Also, could you please close this PR now that we've decided to go the other way? :) |
|
We decided to make this PR canceled for benefits of other PRs |
I believe with this way it will be much suitable for version bumps.
This PR also fixes a small bug about a typo in MANIFEST.in
fixes #44