Skip to content

Fix duplicate self parameter in Bundle easyblock#4057

Open
Flamefire wants to merge 2 commits intoeasybuilders:developfrom
Flamefire:fix-bundle
Open

Fix duplicate self parameter in Bundle easyblock#4057
Flamefire wants to merge 2 commits intoeasybuilders:developfrom
Flamefire:fix-bundle

Conversation

@Flamefire
Copy link
Contributor

Fixes #3778

super().x() already passes self so this was equivalent to EasyBlock.prepare_step(self, self, *args, *kwargs)

Also fix the name in check_checksums as that was very confusing, especially next to each other:

        for comp, _ in self.comp_instances:
        ...
        for _, comp in self.comp_instances:

@Thyre
Copy link
Collaborator

Thyre commented Feb 4, 2026

@boegelbot please test @ jsc-zen3
CORE_CNT=16
EB_ARGS="buildenv-default-foss-2023b.eb OpenSSL-3.eb Circuitscape-5.12.3-Julia-1.9.2.eb Perl-bundle-CPAN-5.38.2-GCCcore-13.3.0.eb gfbf-2024a.eb crypt4gh-1.7-GCC-12.3.0.eb jiter-0.4.1-GCCcore-12.3.0.eb X11-20240607-GCCcore-13.3.0.eb --installpath=/tmp/$USER/ebpr-4057"

@boegelbot
Copy link

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=4057 EB_ARGS="buildenv-default-foss-2023b.eb OpenSSL-3.eb Circuitscape-5.12.3-Julia-1.9.2.eb Perl-bundle-CPAN-5.38.2-GCCcore-13.3.0.eb gfbf-2024a.eb crypt4gh-1.7-GCC-12.3.0.eb jiter-0.4.1-GCCcore-12.3.0.eb X11-20240607-GCCcore-13.3.0.eb --installpath=/tmp/$USER/ebpr-4057" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_4057 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9559

Test results coming soon (I hope)...

Details

- notification for comment with ID 3846400836 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS buildenv-default-foss-2023b.eb

  • SUCCESS OpenSSL-3.eb

  • SUCCESS Circuitscape-5.12.3-Julia-1.9.2.eb

  • SUCCESS Perl-bundle-CPAN-5.38.2-GCCcore-13.3.0.eb

  • SUCCESS gfbf-2024a.eb

  • SUCCESS crypt4gh-1.7-GCC-12.3.0.eb

  • SUCCESS jiter-0.4.1-GCCcore-12.3.0.eb

  • SUCCESS X11-20240607-GCCcore-13.3.0.eb

Build succeeded for 8 out of 8 (total: 3 hours 25 mins 9 secs) (8 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.23
See https://gist.github.com/boegelbot/1671151416aa193364d699f6562e139a for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants