transfer dependencies in Bundle easyblock and fix sanity check for module only#4037
Conversation
|
@boegelbot please test @ jsc-zen3 |
|
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3714731172 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 8 out of 8 (total: 3 hours 13 mins 11 secs) (8 easyconfigs in total) |
|
I'll try a module only and sanity check only build as well, just too see if we get any unexpected results... |
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (total: 9 mins 22 secs) (5 easyconfigs in total) |
|
--module-only Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (total: 1 min 5 secs) (5 easyconfigs in total) |
|
--sanity-check-only Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 5 (total: 4 secs) (5 easyconfigs in total) |
|
Looks like I found two (unrelated) bugs with |
|
I'd consider this a bug, but maybe there's a good reason for it. Unfortunately, I don't see how we can get this fixed for See also https://easybuild.slack.com/archives/C34UA1HT7/p1768235026763329 |
Signed-off-by: Jan André Reuter <j.reuter@fz-juelich.de>
|
Latest commit should've fixed the sanity check, tested with a manual change in the X11 EasyConfig. |
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 5 (total: 4 secs) (5 easyconfigs in total) |
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (total: 1 min 16 secs) (5 easyconfigs in total) |
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (total: 9 mins 28 secs) (5 easyconfigs in total) |
|
@boegelbot please test @ jsc-zen3 |
|
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3774254980 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 8 out of 8 (total: 3 hours 6 mins 25 secs) (8 easyconfigs in total) |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 8 out of 8 (total: 1 hour 42 mins 19 secs) (8 easyconfigs in total) |
|
Fix only in #4057 |
(created using
eb --new-pr)Edit:
--sanity-check-onlyis still broken, see #4037 (comment)Edit 2:
Maybe solved by 5010c6f
During test builds of ROCm-LLVM, one sanity check was failing on
jsc-zen3due to libraries not being found when trying to link a test program. Investigating further, I was able to create a reproducer EasyConfig and EasyBlock (see #4009 (comment)), which mirrored the same issue.When building a normal EasyConfig,
self.toolchain.dependenciesis set to include all the dependencies of the EasyConfig. For a Bundle however, this value is empty. I'm not sure if this is because we're setting most of the values in__init__. Could be.In Framework, the dependencies are initialized during
prepare_step. To correctly transfer the dependencies to components, add aprepare_stepto the Bundle EasyBlock, simply transferring the dependencies as they are.Additionally,
--module-onlyand--sanity-check-onlybuilds were not executing the sanity check of Bundle components. This is due toinstall-stepbeing skipped in both cases. To fix this, move the logic for determining components, for which the sanity check should run, to the sameprepare_step.Resolves #4008, Resolves #4009