Skip to content

Replace deprecated get_api_controller() with api_controller property #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eadwinCode merged 1 commit into from
Feb 20, 2026
Merged

Replace deprecated get_api_controller() with api_controller property #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ninja_extra/controllers/route/route_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def __call__(
*args: Any,
**kwargs: Any,
) -> Any:
_api_controller = self.get_api_controller()
_api_controller = self.api_controller
context = get_route_execution_context(
request,
temporal_response,
Expand Down
2 changes: 1 addition & 1 deletion ninja_extra/details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def _validate_view_path_params(self) -> None:
route_function: "RouteFunction" = (
self.view_func.get_route_function()
)
api_controller = route_function.get_api_controller()
api_controller = route_function.api_controller

view_func = route_function.route.view_func

Expand Down
4 changes: 2 additions & 2 deletions ninja_extra/operation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def _log_action(
)
route_function = self._get_route_function()
if route_function:
api_controller = route_function.get_api_controller()
api_controller = route_function.api_controller

msg = (
f'"{request.method.upper() if request.method else "METHOD NOT FOUND"} - '
Expand Down Expand Up @@ -143,7 +143,7 @@ def get_execution_context(
if hasattr(self.view_func, "get_route_function"):
route_function: "RouteFunction" = self.view_func.get_route_function()

_api_controller = route_function.get_api_controller()
_api_controller = route_function.api_controller
permission_classes = (
route_function.route.permissions or _api_controller.permission_classes # type: ignore[assignment]
)
Expand Down