Skip to content

Replace deprecated get_api_controller() with api_controller property#343

Merged
eadwinCode merged 1 commit intoeadwinCode:masterfrom
kolanos:deprecated-get-api-controller
Feb 20, 2026
Merged

Replace deprecated get_api_controller() with api_controller property#343
eadwinCode merged 1 commit intoeadwinCode:masterfrom
kolanos:deprecated-get-api-controller

Conversation

@kolanos
Copy link
Contributor

@kolanos kolanos commented Feb 15, 2026

The @deprecated for the get_api_controller() method is causing tons of warnings to be fired off because ninja_extra is still using get_api_controller().

The `@deprecated` for the `get_api_controller()` method is causing tons of warnings
to be fired off because ninja_extra is still using `get_api_controller()`.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.05%. Comparing base (7111645) to head (208dd51).
⚠️ Report is 8 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   97.04%   97.05%           
=======================================
  Files          71       71           
  Lines        3048     3051    +3     
=======================================
+ Hits         2958     2961    +3     
  Misses         90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eadwinCode
Copy link
Owner

@kolanos thanks for working on this

@eadwinCode eadwinCode merged commit e432992 into eadwinCode:master Feb 20, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants