Replace deprecated get_api_controller() with api_controller property#343
Merged
eadwinCode merged 1 commit intoeadwinCode:masterfrom Feb 20, 2026
Merged
Conversation
The `@deprecated` for the `get_api_controller()` method is causing tons of warnings to be fired off because ninja_extra is still using `get_api_controller()`.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #343 +/- ##
=======================================
Coverage 97.04% 97.05%
=======================================
Files 71 71
Lines 3048 3051 +3
=======================================
+ Hits 2958 2961 +3
Misses 90 90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
@kolanos thanks for working on this |
eadwinCode
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@deprecatedfor theget_api_controller()method is causing tons of warnings to be fired off because ninja_extra is still usingget_api_controller().