Skip to content

[23355] Remove deprecated windows-2019 runner (backport #270)#271

Merged
MiguelCompany merged 1 commit into2.2.xfrom
mergify/bp/2.2.x/pr-270
Sep 10, 2025
Merged

[23355] Remove deprecated windows-2019 runner (backport #270)#271
MiguelCompany merged 1 commit into2.2.xfrom
mergify/bp/2.2.x/pr-270

Conversation

@mergify
Copy link

@mergify mergify bot commented Jun 26, 2025

Description

This PR updates the Windows GitHub Action Runner from windows-2019 to windows-2022. As Visual Studio 2017 build tools (v141) are no longer installed in this new runner, the PR upgrades also to toolsets to use, moving from v141 (VS2017) and v142 (VS2019) to v142 (VS2019) and v143 (VS2022).

@Mergifyio backport 2.2.x 1.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

This is an automatic backport of pull request #270 done by [Mergify](https://mergify.com).

* Remove deprecated windows-2019 runner

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Upgrade Visual Studio toolset from v141 to v143

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

* Upgrade missing vs-toolset config

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

---------

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit eac23fb)
@MiguelCompany MiguelCompany added this to the v2.2.7 milestone Sep 10, 2025
@MiguelCompany MiguelCompany self-requested a review September 10, 2025 07:56
@MiguelCompany MiguelCompany merged commit 35b1121 into 2.2.x Sep 10, 2025
12 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/2.2.x/pr-270 branch September 10, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants