[23355] Remove deprecated windows-2019 runner by rsanchez15 · Pull Request #270 · eProsima/Fast-CDR

rsanchez15 · 2025-06-25T10:11:38Z

Description

This PR updates the Windows GitHub Action Runner from windows-2019 to windows-2022. As Visual Studio 2017 build tools (v141) are no longer installed in this new runner, the PR upgrades also to toolsets to use, moving from v141 (VS2017) and v142 (VS2019) to v142 (VS2019) and v143 (VS2022).

@Mergifyio backport 2.2.x 1.0.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
N/A Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: CI pass and failing tests are unrelated with the changes.

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

github-advanced-security · 2025-06-25T10:16:21Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

.github/workflows/nightly-windows-ci.yml

Mario-DL

LGTM with green nightly CI
https://github.com/eProsima/Fast-CDR/actions/runs/15896321396

Mario-DL · 2025-06-26T08:03:54Z

Note. In the backports, the nightly file shall be removed

.github/workflows/nightly-windows-ci.yml

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

Mario-DL · 2025-06-26T08:20:20Z

Nightly run
https://github.com/eProsima/Fast-CDR/actions/runs/15896706907

rsanchez15 · 2025-06-26T09:10:30Z

@Mergifyio backport 2.2.x 1.0.x

mergify · 2025-06-26T09:10:39Z

backport 2.2.x 1.0.x

✅ Backports have been created

Details

#271 [23355] Remove deprecated windows-2019 runner (backport #270) has been created for branch 2.2.x
#272 [23355] Remove deprecated windows-2019 runner (backport #270) has been created for branch 1.0.x but encountered conflicts

* Remove deprecated windows-2019 runner Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> * Upgrade Visual Studio toolset from v141 to v143 Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> * Upgrade missing vs-toolset config Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> --------- Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> (cherry picked from commit eac23fb)

* Remove deprecated windows-2019 runner Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> * Upgrade Visual Studio toolset from v141 to v143 Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> * Upgrade missing vs-toolset config Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> --------- Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> (cherry picked from commit eac23fb) # Conflicts: # .github/workflows/nightly-windows-ci.yml # .github/workflows/windows-ci.yml

* Remove deprecated windows-2019 runner * Upgrade Visual Studio toolset from v141 to v143 * Upgrade missing vs-toolset config --------- (cherry picked from commit eac23fb) Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> Co-authored-by: Raul Sanchez-Mateos Lizano <raul@eprosima.com>

* Remove deprecated windows-2019 runner Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> * Upgrade Visual Studio toolset from v141 to v143 Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> * Upgrade missing vs-toolset config Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> --------- Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> (cherry picked from commit eac23fb)

* Remove deprecated windows-2019 runner (#270) * Remove deprecated windows-2019 runner Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> * Upgrade Visual Studio toolset from v141 to v143 Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> * Upgrade missing vs-toolset config Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> --------- Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> (cherry picked from commit eac23fb) * Use ubuntu 22 in CI runner Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Raul Sanchez-Mateos Lizano <raul@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

Remove deprecated windows-2019 runner

77b3da6

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

rsanchez15 requested a review from richiprosima June 25, 2025 10:12

github-actions bot added the ci-pending label Jun 25, 2025

Upgrade Visual Studio toolset from v141 to v143

2bcb9cd

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

rsanchez15 requested a review from richiware June 25, 2025 10:35

rsanchez15 added this to the v2.3.1 milestone Jun 25, 2025

richiware previously approved these changes Jun 25, 2025

View reviewed changes

richiware reviewed Jun 25, 2025

View reviewed changes

.github/workflows/nightly-windows-ci.yml Show resolved Hide resolved

rsanchez15 dismissed richiware’s stale review via 11406f9 June 26, 2025 05:07

rsanchez15 requested review from richiware and removed request for richiprosima June 26, 2025 05:23

Mario-DL changed the title ~~Remove deprecated windows-2019 runner~~ [23355] Remove deprecated windows-2019 runner Jun 26, 2025

Mario-DL approved these changes Jun 26, 2025

View reviewed changes

Mario-DL suggested changes Jun 26, 2025

View reviewed changes

.github/workflows/nightly-windows-ci.yml Show resolved Hide resolved

.github/workflows/nightly-windows-ci.yml Show resolved Hide resolved

Upgrade missing vs-toolset config

643e115

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>

rsanchez15 force-pushed the feature/remove-windows-2019 branch from 11406f9 to 643e115 Compare June 26, 2025 08:16

Mario-DL requested review from Mario-DL and removed request for Mario-DL June 26, 2025 08:31

rsanchez15 merged commit eac23fb into master Jun 26, 2025
16 of 17 checks passed

rsanchez15 deleted the feature/remove-windows-2019 branch June 26, 2025 09:10

mergify bot mentioned this pull request Jun 26, 2025

[23355] Remove deprecated windows-2019 runner (backport #270) #271

Merged

8 tasks

mergify bot mentioned this pull request Jun 26, 2025

[23355] Remove deprecated windows-2019 runner (backport #270) #272

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[23355] Remove deprecated windows-2019 runner#270

[23355] Remove deprecated windows-2019 runner#270
rsanchez15 merged 3 commits intomasterfrom
feature/remove-windows-2019

rsanchez15 commented Jun 25, 2025 •

edited by Mario-DL

Loading

Uh oh!

github-advanced-security bot commented Jun 25, 2025

Uh oh!

Uh oh!

Mario-DL left a comment

Uh oh!

Mario-DL commented Jun 26, 2025

Uh oh!

Uh oh!

Uh oh!

Mario-DL commented Jun 26, 2025

Uh oh!

Uh oh!

rsanchez15 commented Jun 26, 2025 •

edited

Loading

Uh oh!

mergify bot commented Jun 26, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rsanchez15 commented Jun 25, 2025 • edited by Mario-DL Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

github-advanced-security bot commented Jun 25, 2025

Uh oh!

Uh oh!

Mario-DL left a comment

Choose a reason for hiding this comment

Uh oh!

Mario-DL commented Jun 26, 2025

Uh oh!

Uh oh!

Uh oh!

Mario-DL commented Jun 26, 2025

Uh oh!

Uh oh!

rsanchez15 commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rsanchez15 commented Jun 25, 2025 •

edited by Mario-DL

Loading

rsanchez15 commented Jun 26, 2025 •

edited

Loading

mergify bot commented Jun 26, 2025 •

edited

Loading