Skip to content

fix: resolve font height compression when keyboard appears #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
e16tae merged 1 commit into from
Mar 10, 2026
Merged

fix: resolve font height compression when keyboard appears #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions ios/Muxi/Terminal/TerminalRenderer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,12 @@ final class TerminalRenderer: NSObject, MTKViewDelegate {
var buffer: TerminalBuffer?
var needsRedraw: Bool = true

/// Cached viewport size in points, derived from the drawable size.
/// Updated in `drawableSizeWillChange` to guarantee it matches the
/// actual rendering target — unlike `view.bounds`, which can lag
/// behind the drawable during animated resizes (e.g. keyboard).
private var cachedViewportSize: SIMD2<Float> = .zero

// MARK: - Scrollback

/// When set, the renderer reads from this buffer instead of the live buffer.
Expand Down Expand Up @@ -495,11 +501,18 @@ final class TerminalRenderer: NSObject, MTKViewDelegate {
// MARK: - MTKViewDelegate

func mtkView(_ view: MTKView, drawableSizeWillChange size: CGSize) {
let scale = view.contentScaleFactor
cachedViewportSize = SIMD2<Float>(
Float(size.width / scale),
Float(size.height / scale)
)
needsRedraw = true
view.setNeedsDisplay()
}

func draw(in view: MTKView) {
guard let pipelineState,
cachedViewportSize.x > 0, cachedViewportSize.y > 0,
let drawable = view.currentDrawable,
let renderPassDesc = view.currentRenderPassDescriptor,
let commandBuffer = commandQueue.makeCommandBuffer(),
Expand All @@ -517,12 +530,7 @@ final class TerminalRenderer: NSObject, MTKViewDelegate {
needsRedraw = false
}

// Use bounds (points) not drawableSize (pixels) because vertex
// positions are computed in point coordinates (col * cellWidth).
var viewportSize = SIMD2<Float>(
Float(view.bounds.width),
Float(view.bounds.height)
)
var viewportSize = cachedViewportSize

encoder.setRenderPipelineState(pipelineState)

Expand Down
Loading