fix: resolve font height compression when keyboard appears#2
Merged
Conversation
The Metal renderer used view.bounds for viewport calculation in draw(), but bounds can lag behind the drawable size during animated resizes (e.g. keyboard appearance). This caused the vertex shader to map content using stale dimensions, compressing font height vertically. Cache viewport size from drawableSizeWillChange (derived from drawable) and add the missing setNeedsDisplay() call to trigger immediate redraw on resize — matching Apple's standard Metal on-demand rendering pattern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
view.bounds/ drawable size timing mismatch during animated resizedrawableSizeWillChange(drawable-derived, not bounds) to guarantee viewport matches rendering targetsetNeedsDisplay()call to trigger immediate redraw on drawable resizeRoot Cause
draw()readview.boundsfor the shader viewport, but during keyboard animation, bounds can lag behind the already-resized drawable. The stale (larger) viewport caused the vertex shader to map content into a smaller drawable, compressing only the vertical axis (keyboard only changes height).Test plan
🤖 Generated with Claude Code